refactor: combine logic from h_button and h_small_button #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of
h_button()andh_small_button()are almost identical. The only differences are a few size and spacing parameters, andh_small_button()'s support for showing only the svg icon if the button text is empty, which shouldn't impact current usage ofh_button(). This PR pulls the shared logic into a helper function, reducing the implementation of these two existing functions to a single line call.Depends on #258