Skip to content

Commit 9669a0c

Browse files
isheriffAndroid (Google) Code Review
authored andcommitted
Merge "API review fixes" into jb-dev
2 parents 08c0400 + 22af38c commit 9669a0c

File tree

6 files changed

+627
-691
lines changed

6 files changed

+627
-691
lines changed

api/current.txt

Lines changed: 38 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -12708,21 +12708,6 @@ package android.net.http {
1270812708

1270912709
package android.net.nsd {
1271012710

12711-
public class DnsSdServiceInfo implements android.os.Parcelable {
12712-
ctor public DnsSdServiceInfo();
12713-
method public int describeContents();
12714-
method public java.net.InetAddress getHost();
12715-
method public int getPort();
12716-
method public java.lang.String getServiceName();
12717-
method public java.lang.String getServiceType();
12718-
method public void setHost(java.net.InetAddress);
12719-
method public void setPort(int);
12720-
method public void setServiceName(java.lang.String);
12721-
method public void setServiceType(java.lang.String);
12722-
method public void writeToParcel(android.os.Parcel, int);
12723-
field public static final android.os.Parcelable.Creator CREATOR;
12724-
}
12725-
1272612711
public class DnsSdTxtRecord implements android.os.Parcelable {
1272712712
ctor public DnsSdTxtRecord();
1272812713
ctor public DnsSdTxtRecord(byte[]);
@@ -12739,53 +12724,56 @@ package android.net.nsd {
1273912724
field public static final android.os.Parcelable.Creator CREATOR;
1274012725
}
1274112726

12742-
public class NsdManager {
12743-
method public void deinitialize(android.net.nsd.NsdManager.Channel);
12744-
method public void discoverServices(android.net.nsd.NsdManager.Channel, java.lang.String, android.net.nsd.NsdManager.DnsSdDiscoveryListener);
12745-
method public void initialize(android.content.Context, android.os.Looper, android.net.nsd.NsdManager.ChannelListener);
12746-
method public void registerService(android.net.nsd.NsdManager.Channel, java.lang.String, java.lang.String, int, android.net.nsd.NsdManager.DnsSdRegisterListener);
12747-
method public void resolveService(android.net.nsd.NsdManager.Channel, java.lang.String, java.lang.String, android.net.nsd.NsdManager.DnsSdResolveListener);
12748-
method public void stopServiceDiscovery(android.net.nsd.NsdManager.Channel, android.net.nsd.NsdManager.ActionListener);
12749-
method public void unregisterService(android.net.nsd.NsdManager.Channel, int, android.net.nsd.NsdManager.ActionListener);
12727+
public final class NsdManager {
12728+
method public void discoverServices(java.lang.String, int, android.net.nsd.NsdManager.DiscoveryListener);
12729+
method public void registerService(android.net.nsd.NsdServiceInfo, int, android.net.nsd.NsdManager.RegistrationListener);
12730+
method public void resolveService(android.net.nsd.NsdServiceInfo, android.net.nsd.NsdManager.ResolveListener);
12731+
method public void stopServiceDiscovery(android.net.nsd.NsdManager.DiscoveryListener);
12732+
method public void unregisterService(android.net.nsd.NsdManager.RegistrationListener);
1275012733
field public static final java.lang.String ACTION_NSD_STATE_CHANGED = "android.net.nsd.STATE_CHANGED";
12751-
field public static final int ALREADY_ACTIVE = 3; // 0x3
12752-
field public static final int BUSY = 2; // 0x2
12753-
field public static final int ERROR = 0; // 0x0
1275412734
field public static final java.lang.String EXTRA_NSD_STATE = "nsd_state";
12755-
field public static final int MAX_REGS_REACHED = 4; // 0x4
12735+
field public static final int FAILURE_ALREADY_ACTIVE = 3; // 0x3
12736+
field public static final int FAILURE_INTERNAL_ERROR = 0; // 0x0
12737+
field public static final int FAILURE_MAX_LIMIT = 4; // 0x4
1275612738
field public static final int NSD_STATE_DISABLED = 1; // 0x1
1275712739
field public static final int NSD_STATE_ENABLED = 2; // 0x2
12758-
field public static final int UNSUPPORTED = 1; // 0x1
12759-
}
12760-
12761-
public static abstract interface NsdManager.ActionListener {
12762-
method public abstract void onFailure(int);
12763-
method public abstract void onSuccess();
12740+
field public static final int PROTOCOL_DNS_SD = 1; // 0x1
1276412741
}
1276512742

12766-
public static class NsdManager.Channel {
12743+
public static abstract interface NsdManager.DiscoveryListener {
12744+
method public abstract void onDiscoveryStarted(java.lang.String);
12745+
method public abstract void onDiscoveryStopped(java.lang.String);
12746+
method public abstract void onServiceFound(android.net.nsd.NsdServiceInfo);
12747+
method public abstract void onServiceLost(android.net.nsd.NsdServiceInfo);
12748+
method public abstract void onStartDiscoveryFailed(java.lang.String, int);
12749+
method public abstract void onStopDiscoveryFailed(java.lang.String, int);
1276712750
}
1276812751

12769-
public static abstract interface NsdManager.ChannelListener {
12770-
method public abstract void onChannelConnected(android.net.nsd.NsdManager.Channel);
12771-
method public abstract void onChannelDisconnected();
12752+
public static abstract interface NsdManager.RegistrationListener {
12753+
method public abstract void onRegistrationFailed(android.net.nsd.NsdServiceInfo, int);
12754+
method public abstract void onServiceRegistered(android.net.nsd.NsdServiceInfo);
12755+
method public abstract void onServiceUnregistered(android.net.nsd.NsdServiceInfo);
12756+
method public abstract void onUnregistrationFailed(android.net.nsd.NsdServiceInfo, int);
1277212757
}
1277312758

12774-
public static abstract interface NsdManager.DnsSdDiscoveryListener {
12775-
method public abstract void onFailure(int);
12776-
method public abstract void onServiceFound(android.net.nsd.DnsSdServiceInfo);
12777-
method public abstract void onServiceLost(android.net.nsd.DnsSdServiceInfo);
12778-
method public abstract void onStarted(java.lang.String);
12759+
public static abstract interface NsdManager.ResolveListener {
12760+
method public abstract void onResolveFailed(android.net.nsd.NsdServiceInfo, int);
12761+
method public abstract void onServiceResolved(android.net.nsd.NsdServiceInfo);
1277912762
}
1278012763

12781-
public static abstract interface NsdManager.DnsSdRegisterListener {
12782-
method public abstract void onFailure(int);
12783-
method public abstract void onServiceRegistered(int, android.net.nsd.DnsSdServiceInfo);
12784-
}
12785-
12786-
public static abstract interface NsdManager.DnsSdResolveListener {
12787-
method public abstract void onFailure(int);
12788-
method public abstract void onServiceResolved(android.net.nsd.DnsSdServiceInfo);
12764+
public final class NsdServiceInfo implements android.os.Parcelable {
12765+
ctor public NsdServiceInfo();
12766+
method public int describeContents();
12767+
method public java.net.InetAddress getHost();
12768+
method public int getPort();
12769+
method public java.lang.String getServiceName();
12770+
method public java.lang.String getServiceType();
12771+
method public void setHost(java.net.InetAddress);
12772+
method public void setPort(int);
12773+
method public void setServiceName(java.lang.String);
12774+
method public void setServiceType(java.lang.String);
12775+
method public void writeToParcel(android.os.Parcel, int);
12776+
field public static final android.os.Parcelable.Creator CREATOR;
1278912777
}
1279012778

1279112779
}

core/java/android/app/ContextImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ public Object createService(ContextImpl ctx) {
387387
public Object createService(ContextImpl ctx) {
388388
IBinder b = ServiceManager.getService(NSD_SERVICE);
389389
INsdManager service = INsdManager.Stub.asInterface(b);
390-
return new NsdManager(service);
390+
return new NsdManager(ctx.getOuterContext(), service);
391391
}});
392392

393393
// Note: this was previously cached in a static variable, but

core/java/android/net/nsd/NetworkServiceInfo.java

Lines changed: 0 additions & 32 deletions
This file was deleted.

0 commit comments

Comments
 (0)