Skip to content

Commit fe19f12

Browse files
Matthew XieAndroid (Google) Code Review
authored andcommitted
Add TODO comments to remove start/stopReverseTethering
Change start/stopReverseTethering permission from CHANGE_NETWORK_STATE to CONNECTIVITY_INTERNAL Change-Id: Iac76d5af6418e6a3e2d2f77bf713466981285e1a
1 parent 6fde309 commit fe19f12

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

services/java/com/android/server/NetworkManagementService.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -780,11 +780,12 @@ public boolean isTetheringStarted() {
780780
event.checkCode(TetherStatusResult);
781781
return event.getMessage().endsWith("started");
782782
}
783+
784+
// TODO(BT) Remove
783785
public void startReverseTethering(String iface)
784786
throws IllegalStateException {
785787
if (DBG) Slog.d(TAG, "startReverseTethering in");
786-
mContext.enforceCallingOrSelfPermission(
787-
android.Manifest.permission.CHANGE_NETWORK_STATE, "NetworkManagementService");
788+
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
788789
// cmd is "tether start first_start first_stop second_start second_stop ..."
789790
// an odd number of addrs will fail
790791
String cmd = "tether start-reverse";
@@ -798,9 +799,10 @@ public void startReverseTethering(String iface)
798799
BluetoothTetheringDataTracker.getInstance().startReverseTether(iface);
799800

800801
}
802+
803+
// TODO(BT) Remove
801804
public void stopReverseTethering() throws IllegalStateException {
802-
mContext.enforceCallingOrSelfPermission(
803-
android.Manifest.permission.CHANGE_NETWORK_STATE, "NetworkManagementService");
805+
mContext.enforceCallingOrSelfPermission(CONNECTIVITY_INTERNAL, TAG);
804806
try {
805807
mConnector.doCommand("tether stop-reverse");
806808
} catch (NativeDaemonConnectorException e) {

0 commit comments

Comments
 (0)