Artur man/multichannel #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hurra. Looks like it's clean now. Will get to it when I can. Muchas gracias, amigo. |
HelenaLC
reviewed
Nov 25, 2024
| # normalize the image data given its data type | ||
| #' @noRd | ||
| .normalize_image_array <- \(a, dt){ | ||
| if(dt %in% names(.DTYPE_MAX_VALUES)) a <- a/.DTYPE_MAX_VALUES[[dt]] |
Owner
There was a problem hiding this comment.
can u clarify - are there missing curly brackets here? looks like the else will be evaluated in any case, which will give an error?
HelenaLC
reviewed
Nov 25, 2024
HelenaLC
added a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding utilities to manage/merge multiple channels
.is.rgbfunction allows to detect rgb images.zattrsIssues: HelenaLC/SpatialData#85 HelenaLC/SpatialData#86