Implementation of Super Mario Bros

[RadzPrower]

Implementation of Super Mario Bros.

Includes support for the following ROM versions:

• (World)
• (Japan, USA)
• (E)

Has the following 4 types of quests:

• Score - Collect 100,000 points
• Worlds - Complete one of Bowser's Castles
• Streak - Complete five consecutive levels without dying (warps not included)
• Damageless - Complete a level without dying or taking damage

[CalDrac]

Hi, I cloned your branch, i encountered some bugs

BizHawk 2.9.1, NesHawk, Super Mario Bros (Japan, USA) rom

[RadzPrower]

What specifically had you done when it happened? I tried to account for a max score increase to prevent RAM manipulation, but that value must've been too low.

[CalDrac]

I just played he game, score wasn't increasing and streak / damageless went up without me doing anything

[RadzPrower]

I'll have to check tomorrow, but it's odd that the level related things were incrementing on their own and the score was spamming that message. I put in some code to try and prevent that sort of message spam when the value was too high.

Had you advanced beyond the title screen before connecting perhaps?

[RadzPrower]

I have no idea what happened with yours last night. I've been messing with it this morning (with a (Japan, USA) version and I cannot replicate the message spam. I tried starting the HintMachine in the middle of a game and while it did trigger the anti-cheat and the score was no longer tracked, there was no message spam.

I also played through almost half the game vanilla and collected on the score quest 2-3 times, 3 worlds, a couple of streaks, and many damageless without any issues.

It's starting to look like an issue with finding the correct RAM in the emulator perhaps? That might explain the message spam since I did allow for the cheater flag to be reset if the score were to reset to zero (died or game reset), so if the score is being set back to zero at a regular interval (a timer for instance) it would reset that flag and then allow for the message spam.