fix: correctly read env on workers#21
Closed
Barbapapazes wants to merge 1 commit intoHugoRCD:mainfrom
Closed
Conversation
|
@Barbapapazes is attempting to deploy a commit to the HRCD Projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 |
Contributor
Author
|
it does not work related to unjs/std-env#162 |
Contributor
Author
|
The only way to have it to work is by using import { env } from 'cloudflare:workers'
import { initLogger, createRequestLogger } from 'evlog'
initLogger({
pretty: env.NODE_ENV !== 'production',
}) |
Contributor
Author
|
Maybe, we should dedicate a section to explain how to use evlog with Cloudflare Workers at it don't seems to be fixable. |
Owner
Will this work if the issue is fixed ? Maybe we can push the issue ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋,
To init the logger for a Cloudflare Workers, we have to do it outsite of the main
fetch:However,
processisn't defined soisDevis always false, even in production whereNODE_ENVis set toproduction.I think it could be solve by importing
node:envbut it could have some undesirable side-effects. So, I think usingglobalThisis a better solution and to avoid to add to much complexity to your package, I proposestd-envthat makes it easy.