FEATURE : Portfolio duplication (closes #190)#198
FEATURE : Portfolio duplication (closes #190)#198AxelRagobert wants to merge 3 commits intoHypertopic:v7from
Conversation
|
Thank you for this nice contribution. Could you please restructure the history into 2 commits (one for the FEATURE and one for the TEST) as specified by the rules? ... especially those about other contributors (if any) and ticket reference. |
|
Done ! |
|
Understanding your note of this morning, I've pended my duplication test. Here are some manipulations you'll have to make to make it work. As a reminder, this issue is due to the CORS settings. Change by in package.json Change in config/config.json Launch the reverse proxy in the folder reverse-proxy with sudo npm start. Then the duplication test should succeed. |
|
It seems that npm install doesn't work on Travis. It's maybe a server issue.. |
These commits allow you to duplicate a portfolio if you are connected. It also makes porphyry more responsive.
However to be able to test the duplication, you have to change the url from localhost:3000 to portfolioName.local:3000 and modify your /etc/hosts file to match these kind URIs with 127.0.0.1. You also have to run a small reverse-proxy which is a the root of the project.
Please check that your pull request is correct:
FEATUREfor a behaviour allowing a user to do something new,FIXfor a behaviour which has been changed in order to meet user’s expectations,TESTwhen it concerns an acceptance test,PROCESSfor a change in the way the software is built, tested, deployed,DOCwhen it concerns only internal documentation (however it is better to combine it with the contribution that required this documentation change),:) with one space after and no space before,manage),should).(closes #xx)if xx is a feature ticket (and the commit is a complete implementation),(fixes #xx)if xx is a fix ticket (and the commit is a complete fix),(see #xx)otherwise,