FEATURE: Topic cloud & fragment view by arnaud9145 · Pull Request #200 · Hypertopic/Porphyry

arnaud9145 · 2019-06-14T08:57:18Z

Content

Implemented fragment and cloud view
@arnaud9145, @taher100, @sab91 and @GuillaumeGilles42 for implementation
@Double-Ramzi and @qdelcourte

Checklist

Please check that your pull request is correct:

Each commit:
- corresponds to a contribution that should be notified to users,
- does not generate new errors or warnings at compile or test time,
- must be attributed to its real authors (with correct GitHub IDs and correct syntax for multiple authors).
The title of a commit should:
- begin with a contribution type
  - FEATURE for a behaviour allowing a user to do something new,
  - FIX for a behaviour which has been changed in order to meet user’s expectations,
  - TEST when it concerns an acceptance test,
  - PROCESS for a change in the way the software is built, tested, deployed,
  - DOC when it concerns only internal documentation (however it is better to combine it with the contribution that required this documentation change),
- be followed by a colon (:) with one space after and no space before,
- be followed by a title (written in English) as short, as user-centered and as explicit as possible
  - If it is a feature, the title must be the user action (beginning with a verb, and please not manage),
  - If it is a fix, the title must describe the intended behavior (with should).
- ends with a reference to the corresponding ticket with the following syntax:
  - (closes #xx) if xx is a feature ticket (and the commit is a complete implementation),
  - (fixes #xx) if xx is a fix ticket (and the commit is a complete fix),
  - (see #xx) otherwise,
Each committed line is:
- useful (it would not work if removed)
  - if it is a comment line, its information could not be conveyed by better variables and function naming, better code structuring, or better commit message,
- related to this very contribution (feature, fix...),
- in English (with the exception of Gherkin scenarios in French and resulting steps),
- without any typo in variable, class or function names,
- correctly indented (spaces rather than tabs, same number of characters as in the rest of the file).

features/images_appartient_rubrique.feature

benel · 2019-06-14T12:21:47Z

features/step_definitions/fragment.rb

@@ -0,0 +1,62 @@
+require 'capybara/cucumber'


There is one step definition file per Web page.
Since there is no "fragment" page, this file should not exist.
Please move the needed steps (and only them) into existing files.

benel · 2019-06-14T12:23:44Z

features/step_definitions/fragment.rb

+   expect(page).to have_selector('.Items .item', count: int)
+end
+
+Alors("l'item {string} est décrit par une date") do |item|


A date? Which one?
Please note that scenarios should include samples therefore steps should include parameters.

benel · 2019-06-14T12:23:57Z

features/step_definitions/fragment.rb

+   expect(parent).to have_selector('.date')
+end
+
+Alors("l'item {string} est décrit par un auteur") do |item|


benel · 2019-06-14T12:24:57Z

features/step_definitions/images_appartient_rubrique.rb

+Capybara.app_host = "http://localhost:3000"
+Capybara.default_max_wait_time = 10
+
+def getUUID2(itemName)


Please reuse existing methods (and edit them if necessary).

benel · 2019-06-14T12:27:31Z

src/components/App/App.jsx

+import { BrowserRouter as Router, Route, Switch } from 'react-router-dom'
+import Portfolio from '../Portfolio/Portfolio.jsx'
+import Item from '../Item/Item.jsx'
+import Outliner from '../Outliner/Outliner.jsx'


Don't edit lines if it is not part of the feature you are implementing (it would mess completely the "blame" feature, and moreover it makes edition conflicts more likely).

benel · 2019-06-14T12:27:40Z

src/components/App/App.jsx

-          <Route path="/" component={Portfolio} />
+          <Route path='/item/:corpus/:item' component={Item} />
+          <Route path='/viewpoint/:id' component={Outliner} />
+          <Route path='/' component={Portfolio} />


benel · 2019-06-14T12:27:49Z

src/components/App/App.jsx

      </Router>
    )
  }
-


benel · 2019-06-14T12:27:58Z

src/components/App/App.jsx

 }

-export default App;
+export default App


benel · 2019-06-14T12:28:08Z

src/components/Authenticated/Authenticated.jsx

+import conf from '../../config/config.json'

-const SESSION_URI = conf.services[0] + '/_session';
+const SESSION_URI = conf.services[0] + '/_session'


I'm fed up. Please scan each diff line yourself. And check EVERY rule before requesting for a pull.

…c#80). Co-authored-by: Arnaud Dufour <arnaud.dufour@utt.fr> Co-authored-by: Guillaume Gilles <48546298+GuillaumeGilles42@users.noreply.github.com>

…ertopic#80). Co-authored-by: Taher Kamoun <taherkamoun5@gmail.com> Co-authored-by: Victor Kodais-Loquet <victor.kodais-loquet@hotmail.fr> Co-authored-by: Quentin Delcourte <delcourte.quentin@hotmail.com>

vl-gx changed the title ~~Final version group entretient~~ Final version group entretien Jun 14, 2019

benel requested changes Jun 14, 2019

View reviewed changes

arnaud9145 force-pushed the final-version-p19 branch 2 times, most recently from da07949 to ebe7b6c Compare June 21, 2019 09:30

sabri.ben_miled and others added 2 commits June 21, 2019 19:13

FEATURE: Add cloud and fragment view (see Hypertopic#48 and Hypertopi…

03d5929

…c#80). Co-authored-by: Arnaud Dufour <arnaud.dufour@utt.fr> Co-authored-by: Guillaume Gilles <48546298+GuillaumeGilles42@users.noreply.github.com>

TEST: Tests for cloud and fragment view (closes Hypertopic#48 and Hyp…

8c45887

…ertopic#80). Co-authored-by: Taher Kamoun <taherkamoun5@gmail.com> Co-authored-by: Victor Kodais-Loquet <victor.kodais-loquet@hotmail.fr> Co-authored-by: Quentin Delcourte <delcourte.quentin@hotmail.com>

sab91 force-pushed the final-version-p19 branch from ebe7b6c to 8c45887 Compare June 21, 2019 17:43

benel added the Draft label Mar 19, 2020

benel changed the title ~~Final version group entretien~~ FEATURE: Topic cloud & fragment view Apr 28, 2020

benel marked this pull request as draft April 29, 2020 09:48

benel removed the Draft label Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FEATURE: Topic cloud & fragment view#200

FEATURE: Topic cloud & fragment view#200
arnaud9145 wants to merge 2 commits intoHypertopic:v7from
GuillaumeGilles42:final-version-p19

arnaud9145 commented Jun 14, 2019 •

edited by sab91

Loading

Uh oh!

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

benel Jun 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

arnaud9145 commented Jun 14, 2019 • edited by sab91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arnaud9145 commented Jun 14, 2019 •

edited by sab91

Loading