Skip to content

Conversation

@dangunter
Copy link
Member

@dangunter dangunter commented Mar 18, 2025

Copyright up to 2025

2025 is this year.


Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--139.org.readthedocs.build/en/139/

@dangunter dangunter requested a review from lbianchi-lbl March 18, 2025 21:33
@dangunter
Copy link
Member Author

I think the changes are more logical than the previous attempt (where random code snippets seemed changed), but tests are failing fast and furious right now. Any ideas are welcome, but no need to review until I figure that out.

@lbianchi-lbl
Copy link
Contributor

  • There are a lot of changes showing up that are not strictly related with the change 2023 -> 2025
  • I think most of these are expected for Jupyter notebooks and/or not consequential (e.g. the addition of cell.id)
  • However, some of them look like something we should resolve before merging, such as this error being added:
    image

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 20, 2025
@ksbeattie
Copy link
Member

@dangunter will take another run at this.

@ksbeattie ksbeattie closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:Normal Normal Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants