WN-252 #8
Merged
WN-252 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 18, 2025 13:50
joseganora
reviewed
Feb 18, 2025
| Schema::dropIfExists('contributors'); | ||
| Schema::create('contributors', function (Blueprint $table) { | ||
| $table->increments('id'); | ||
| $table->text('name'); |
Collaborator
There was a problem hiding this comment.
add the length of this column and others
Collaborator
There was a problem hiding this comment.
Use string and set the lenght $table->string('name', "MAX");
Collaborator
Author
There was a problem hiding this comment.
I set the length for the columns.
For the logo column, I set the length to 2048 to store signed URLs.
joseganora
requested changes
Feb 18, 2025
Collaborator
joseganora
left a comment
joseganora
left a comment
There was a problem hiding this comment.
Check the comment on the migration
joseganora
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.