-
Notifications
You must be signed in to change notification settings - Fork 22
CoDICE: Production preparation #2562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
| <!-- TODO: undo this in coming DE segmented work --> | ||
| <!-- <xtce:IntegerParameterType name="COD_LO_PHA.SHCOARSE" signed="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you undoing this change? Can't we leave it in if you are skipping DEs.
I think we should have the XTCE be what it is and not comment things out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so keep it as we want in the upcoming work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. I will uncomment these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would prefer the XTCE to be exactly what I put in the other branch.
Although now I'm wondering if the tests will work with that update or not...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True..the tests will fail but I need to skip them anyway. So your suggestion works for me still.
I haven't done the thorough tests yet because I am getting this draft PR up so that Luisa can test in dev if she gets chance today. Then I will resume dev testing my tomorrow.
Change Summary
Overview
This code changes gets CoDICE non-DE products ready for production. DE preparation will come later.
NOTE:
I checked the CLI and they seem ready. I feel like this is all we need at the moment but dev test with latest LUT file will tell us. I am keeping this in draft PR until dev test is ok.