Skip to content

Conversation

@tech3371
Copy link
Contributor

@tech3371 tech3371 commented Jan 8, 2026

Change Summary

Overview

This code changes gets CoDICE non-DE products ready for production. DE preparation will come later.

NOTE:
I checked the CLI and they seem ready. I feel like this is all we need at the moment but dev test with latest LUT file will tell us. I am keeping this in draft PR until dev test is ok.

@tech3371 tech3371 requested review from greglucas and lacoak21 January 8, 2026 15:37
@tech3371 tech3371 self-assigned this Jan 8, 2026
@tech3371 tech3371 added the Ins: CoDICE Related to the CoDICE instrument label Jan 8, 2026
Comment on lines 1531 to 1532
<!-- TODO: undo this in coming DE segmented work -->
<!-- <xtce:IntegerParameterType name="COD_LO_PHA.SHCOARSE" signed="false">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you undoing this change? Can't we leave it in if you are skipping DEs.

I think we should have the XTCE be what it is and not comment things out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so keep it as we want in the upcoming work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. I will uncomment these

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would prefer the XTCE to be exactly what I put in the other branch.

Although now I'm wondering if the tests will work with that update or not...

Copy link
Contributor Author

@tech3371 tech3371 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True..the tests will fail but I need to skip them anyway. So your suggestion works for me still.

I haven't done the thorough tests yet because I am getting this draft PR up so that Luisa can test in dev if she gets chance today. Then I will resume dev testing my tomorrow.

@tech3371 tech3371 linked an issue Jan 16, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ins: CoDICE Related to the CoDICE instrument

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use codice_packet_definition.xml for housekeeping decom

3 participants