Ultra segmented packet support #2581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
added
Ins: Ultra
greglucas
force-pushed
the
ultra-continuation-packets
branch
from
6bedcd9 to
f6df9a3
Compare
tech3371
reviewed
Jan 16, 2026
Contributor
tech3371
left a comment
tech3371
left a comment
There was a problem hiding this comment.
the changes looks good to me. It's coming nicely together! Nice work!
imap_processing/utils.py
Outdated
| """ | ||
| Combine segmented packets into unsegmented packets. | ||
| All packets have (SHCOARSE, EVENT_DATA, CHKSUM) fields. To combine |
Contributor
There was a problem hiding this comment.
should we update this to be generic now?
Suggested change
| All packets have (SHCOARSE, EVENT_DATA, CHKSUM) fields. To combine | |
| All packets have (SHCOARSE, binary_field_name) fields. To combine |
Collaborator
Author
There was a problem hiding this comment.
Good call! I reworded this to update it and remove CoDICE things that I copied over.
tech3371
approved these changes
Jan 16, 2026
This adds a helper function to combine segmented packets together after XTCE parsing. We can't handle this in the XTCE definition itself due to the variable length packets. We also need to update the Ultra packet definition to have a larger variable length field because the header items are actually only stored in the first packet, not all the middle/last packets too.
greglucas
force-pushed
the
ultra-continuation-packets
branch
from
f6df9a3 to
01067e3
Compare
greglucas
merged commit a6e8f1a
into
IMAP-Science-Operations-Center:dev
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This adds a general helper to combine segmented packets together after the XTCE parsing. This required an updated to the XTCE xml so that the header fields aren't read in on the middle/last packets. This means we need to extract those fields manually after the XTCE parsing and combining of segmented packets. That is ultra specific, so I put the extraction function in the Ultra namespace.