Skip to content

fix(grid): fix out of bounds row index when navigating down from last layout row - 20.1.x #16757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IMinchev64 wants to merge 3 commits into
base: 20.1.x
Choose a base branch
from
Open

fix(grid): fix out of bounds row index when navigating down from last layout row - 20.1.x #16757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de0bed1
fix(grid): fix out of bounds row index when navigating down from last…
IMinchev64 Jan 14, 2026
db37e64
fix(grid): remove out of bounds check for next row navigation
IMinchev64 Jan 15, 2026
d9203e6
test(grid): import IgxGridMRLNavigationService for keyboard navigatio…
IMinchev64 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion projects/igniteui-angular/src/lib/grids/grid-mrl-navigation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,8 @@ export class IgxGridMRLNavigationService extends IgxGridNavigationService {

private hasNextVerticalPosition(prev = false) {
if ((prev && this.activeNode.row === 0 && (!this.isDataRow(this.activeNode.row) || this.activeNode.layout.rowStart === 1)) ||
(!prev && this.activeNode.row >= this.grid.dataView.length - 1 && this.activeNode.column === this.lastColIndexPerMRLBlock())) {
(!prev && this.activeNode.row >= this.grid.dataView.length - 1 &&
this.activeNode.layout.rowStart === this.lastRowStartPerBlock())) {
return false;
}
return true;
Expand Down
35 changes: 35 additions & 0 deletions projects/igniteui-angular/src/lib/grids/grid/grid-mrl-keyboard-nav.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { GridFunctions, GRID_MRL_BLOCK } from '../../test-utils/grid-functions.s
import { CellType } from '../common/grid.interface';
import { IgxColumnLayoutComponent } from '../columns/column-layout.component';
import { IGridCellEventArgs, IgxColumnComponent } from '../public_api';
import { IgxGridMRLNavigationService } from '../grid-mrl-navigation.service';

const DEBOUNCE_TIME = 30;
const CELL_CSS_CLASS = '.igx-grid__td';
Expand Down Expand Up @@ -297,6 +298,40 @@ describe('IgxGrid Multi Row Layout - Keyboard navigation #grid', () => {
GridFunctions.verifyGridContentActiveDescendant(GridFunctions.getGridContent(fix), cell.nativeElement.id);
});

it('should not return an out of bounds row index when navigating down from the last layout row', () => {
fix.componentInstance.data = SampleTestData.contactInfoDataFull().slice(0, 10);
fix.componentInstance.colGroups = [{
group: 'group1',
columns: [
{ field: 'ID', rowStart: 1, colStart: 1 },
{ field: 'CompanyName', rowStart: 1, colStart: 2 },
{ field: 'ContactName', rowStart: 1, colStart: 3 },
{ field: 'ContactTitle', rowStart: 1, colStart: 4 },
{ field: 'Address', rowStart: 1, colStart: 5 },
{ field: 'City', rowStart: 2, colStart: 1 },
{ field: 'Region', rowStart: 2, colStart: 2 },
{ field: 'PostalCode', rowStart: 2, colStart: 3 },
{ field: 'Phone', rowStart: 2, colStart: 4 },
{ field: 'Fax', rowStart: 2, colStart: 5 }
]
}];
fix.detectChanges();

const grid = fix.componentInstance.grid;
const lastRowIndex = grid.dataView.length - 1;
const navService = grid.navigation as IgxGridMRLNavigationService;
const col = grid.getColumnByName('City');
navService.setActiveNode({
row: lastRowIndex,
column: col.visibleIndex,
layout: navService.layout(col.visibleIndex)
});

const nextPos = navService.getNextVerticalPosition();
expect(nextPos.row).toBe(lastRowIndex);
expect(nextPos.column).toBe(navService.activeNode.column);
});

it('should navigate up correctly', () => {
fix.componentInstance.colGroups = [{
group: 'group1',
Expand Down
Loading