[POC] Refactor virtualization resize observer to track individual forOf elements. #16809
+192
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 22, 2026 16:52
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| @@ -0,0 +1,40 @@ | |||
| import { Component, inject, ViewChild } from '@angular/core'; | |||
| import { GridColumnDataType, IGX_GRID_DIRECTIVES, IgxColumnComponent, IgxGridComponent, IgxHierarchicalGridComponent, IgxRowIslandComponent } from "igniteui-angular" | |||
| import { GridColumnDataType, IGX_GRID_DIRECTIVES, IgxColumnComponent, IgxGridComponent, IgxHierarchicalGridComponent, IgxRowIslandComponent } from "igniteui-angular" | ||
| import { DataService } from '../services/data.service'; | ||
| import { ActivatedRoute } from '@angular/router'; | ||
| import { IgxRowIslandAPIService } from 'igniteui-angular/grids/hierarchical-grid/src/row-island-api.service'; |
added 8 commits
January 28, 2026 10:26
| fix.detectChanges(); | ||
|
|
||
| const allRows = grid.tbody.nativeElement.firstElementChild.children; | ||
| const allRows = [...grid.tbody.nativeElement.firstElementChild.children].map(x=> x.children[0]) |
| fix.detectChanges(); | ||
|
|
||
| const allRows = grid.tbody.nativeElement.firstElementChild.children; | ||
| const allRows = [...grid.tbody.nativeElement.firstElementChild.children].map(x=> x.children[0]) |
| grid.summaryPosition = GridSummaryPosition.top; | ||
| fix.detectChanges(); | ||
| const allRows = grid.tbody.nativeElement.firstElementChild.children; | ||
| const allRows = [...grid.tbody.nativeElement.firstElementChild.children].map(x=> x.children[0]) |
| it(`Should correctly position summary rows when summary | ||
| row position is bottom after grouping by and detail views for the group rows are collapsed.`, () => { | ||
| const allRows = grid.tbody.nativeElement.firstElementChild.children; | ||
| const allRows = [...grid.tbody.nativeElement.firstElementChild.children].map(x=> x.children[0]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16821
Attach observer to individual root node views so that they track any change individually for that view. Update size accordingly.
Cache sizes of embedded views and use the cache when updating virtualization caches on scroll.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)