Skip to content

[Draft] ANN clustering: Add unlimited zoom handling #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igoroctaviano wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Draft] ANN clustering: Add unlimited zoom handling #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions src/viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3827,15 +3827,36 @@ class VolumeImageViewer {
const maxZoom = view.getMaxZoom()
const isHighResolution = () => {
const isZoomUnlimited = this[_mapViewResolutions] === undefined
const highestResolution = this[_tileGrid].getResolutions()[0]
const updatedMaxZoom = isZoomUnlimited ? highestResolution : (this[_annotationOptions].maxZoom || maxZoom)
const zoom = isZoomUnlimited ? (view.getZoom() * this[_tileGrid].getResolutions().length) : view.getZoom()
console.debug('Zoom:', zoom)
console.debug('Max Zoom:', updatedMaxZoom)
console.debug('Original Max Zoom:', maxZoom)
console.debug('Highest Resolution:', highestResolution)
console.debug('Resolutions:', this[_tileGrid].getResolutions().length)
return zoom >= updatedMaxZoom
const resolutions = this[_tileGrid].getResolutions()
const highestResolution = resolutions[0] // Largest resolution value (lowest zoom)
if (isZoomUnlimited) {
// When zoom is unlimited, we need to determine which resolution level corresponds to "high resolution"
// Use the resolution at the original max zoom level, or the smallest resolution if maxZoom is not available
const targetMaxZoom = this[_annotationOptions].maxZoom || maxZoom
const targetResolutionIndex = targetMaxZoom != null && targetMaxZoom < resolutions.length
? targetMaxZoom
: resolutions.length - 1
const targetResolution = resolutions[targetResolutionIndex]
// In OpenLayers, smaller resolution = higher zoom (more detail)
// If current resolution <= target resolution, we're at or above the high resolution threshold
const currentResolution = view.getResolution()
console.debug('Zoom: unlimited')
console.debug('Current Resolution:', currentResolution)
console.debug('Target Resolution (at maxZoom):', targetResolution)
console.debug('Target Max Zoom Index:', targetResolutionIndex)
console.debug('Highest Resolution (lowest zoom):', highestResolution)
console.debug('Resolutions:', resolutions.length)
return currentResolution <= targetResolution
} else {
const updatedMaxZoom = this[_annotationOptions].maxZoom || maxZoom
const zoom = view.getZoom()
console.debug('Zoom:', zoom)
console.debug('Max Zoom:', updatedMaxZoom)
console.debug('Original Max Zoom:', maxZoom)
console.debug('Highest Resolution:', highestResolution)
console.debug('Resolutions:', resolutions.length)
return zoom >= updatedMaxZoom
}
}

/**
Expand Down