fix: force load non-standard DICOM files

[ziqiangxu]

No description provided.

[pieper]

Thanks for the contribution 👍

My main comment here is that this probably should be an optional parameter to the constructor with the default being False so we don't change the behavior of the API. Perhaps also there should be a setter so people can turn it on or off for a given client instance.

Also, just as a matter of convention we like to have more verbose commit messages that describe the motivation and design considerations for the suggested change. Doing this in an issue can help but for something simple like this providing more a more detailed commit message will let us discuss any issues here in the PR thread.

@CPBridge @hackermd or others may also want to comment.

[CPBridge]

Agreed, I would certainly not want force loading of non-standard files to be default behaviour here. If we want to implement this, we should add a force parameter, and pass it down from the various top-level public methods (retrieve_study(), retrieve_series(), retrieve_instance() etc). @ziqiangxu would you be interested in making those changes

[CPBridge]

This would need to be an optional parameter, with default False, and be passed down from the various public methods that call _http_get_multipart_application_dicom

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE