Skip to content

Conversation

@wayfarer3130
Copy link

Update the paths for loading the dicom-microscopy-viewer

@deepsource-io
Copy link

deepsource-io bot commented Jul 25, 2025

Here's the code health analysis summary for commits 9a4dbce..7ec0a61. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

alias: {
'dicom-microscopy-viewer':
'dicom-microscopy-viewer/dist/dynamic-import/dicomMicroscopyViewer.min.js'
'dicom-microscopy-viewer/dynamic-import'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the current way of writing exports in ECMAscript, so I think we should use this setup.

{
from: './node_modules/dicom-microscopy-viewer/dist/dynamic-import',
to: './static/js'
to: './'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create settings to specify the sub-path for dicom-microscopy-viewer so that this gets the right sub-path. My preference is still to use a dicom-microscopy-viewer sub path, eg
./static/js/dicom-microscopy-viewer/...
to ensure isolation between any other modules and htis one.

@fedorov fedorov requested a review from igoroctaviano August 5, 2025 02:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2025

@igoroctaviano
Copy link
Collaborator

@wayfarer3130, is this ready to review? (works with slim)?

@wayfarer3130
Copy link
Author

@wayfarer3130, is this ready to review? (works with slim)?

I still need to fix the alternate public path for SLIM in a way that will also work with OHIF - I know how to do that now, just need an hour to do it.

@wayfarer3130
Copy link
Author

This is no longer required as the path changes are compatible with current slim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants