-
Notifications
You must be signed in to change notification settings - Fork 44
fix: Use specified dicom-microscopy-viewer load path #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use specified dicom-microscopy-viewer load path #313
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
| alias: { | ||
| 'dicom-microscopy-viewer': | ||
| 'dicom-microscopy-viewer/dist/dynamic-import/dicomMicroscopyViewer.min.js' | ||
| 'dicom-microscopy-viewer/dynamic-import' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the current way of writing exports in ECMAscript, so I think we should use this setup.
| { | ||
| from: './node_modules/dicom-microscopy-viewer/dist/dynamic-import', | ||
| to: './static/js' | ||
| to: './' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can create settings to specify the sub-path for dicom-microscopy-viewer so that this gets the right sub-path. My preference is still to use a dicom-microscopy-viewer sub path, eg
./static/js/dicom-microscopy-viewer/...
to ensure isolation between any other modules and htis one.
|
|
@wayfarer3130, is this ready to review? (works with slim)? |
I still need to fix the alternate public path for SLIM in a way that will also work with OHIF - I know how to do that now, just need an hour to do it. |
|
This is no longer required as the path changes are compatible with current slim. |



Update the paths for loading the dicom-microscopy-viewer