Skip to content

fix: Thumbnail fallback and multiple thumbnail using dicom tag browser #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igoroctaviano merged 2 commits into from
Oct 10, 2025
Merged

fix: Thumbnail fallback and multiple thumbnail using dicom tag browser #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fa9cb8
Fix thumbnail and multiple thumbnail using dicom tag browser
igoroctaviano Oct 10, 2025
b45e21b
Lint
igoroctaviano Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/components/SlideItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ class SlideItem extends React.Component<SlideItemProps, SlideItemState> {
`instantiate viewer for ${imageType} image of slide ` +
`"${metadata.ContainerIdentifier}"`
)
// For thumbnails, use a much smaller resizeFactor to ensure the entire image fits
const resizeFactor = imageType === 'THUMBNAIL' ? 0.3 : 1

const resizeFactor = 1
this.overviewViewer = new dmv.viewer.OverviewImageViewer({
client: this.props.clients[
StorageClasses.VL_WHOLE_SLIDE_MICROSCOPY_IMAGE
Expand All @@ -79,16 +77,6 @@ class SlideItem extends React.Component<SlideItemProps, SlideItemState> {
this.overviewViewer.render({
container: this.overviewViewportRef.current
})

// For thumbnail images, ensure proper fitting after render
if (imageType === 'THUMBNAIL') {
setTimeout(() => {
if (this.overviewViewer !== undefined) {
// Force resize to ensure proper fitting
this.overviewViewer.resize()
}
}, 100)
}
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/data/slides.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,7 @@ const createSlides = (
images: [
...item.volumeImages,
...item.labelImages,
...item.overviewImages,
...item.thumbnailImages
...item.overviewImages
]
})
})
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11496,9 +11496,9 @@ semver@7.6.0, semver@^7.1.2, semver@^7.5.2:
lru-cache "^6.0.0"

semver@^7.3.5, semver@^7.3.7:
version "7.7.2"
resolved "https://registry.yarnpkg.com/semver/-/semver-7.7.2.tgz#67d99fdcd35cec21e6f8b87a7fd515a33f982b58"
integrity sha512-RF0Fw+rO5AMf9MAyaRXI4AV0Ulj5lMHqVxxdSgiVbixSCXoEmmX/jk0CuJw4+3SqroYO9VoUh+HcuJivvtJemA==
version "7.7.3"
resolved "https://registry.yarnpkg.com/semver/-/semver-7.7.3.tgz#4b5f4143d007633a8dc671cd0a6ef9147b8bb946"
integrity sha512-SdsKMrI9TdgjdweUSR9MweHA4EJ8YxHn8DFaDisvhVlUOe4BF1tLD7GAj0lIqWVl+dPb/rExr0Btby5loQm20Q==

send@0.19.0:
version "0.19.0"
Expand Down