-
Notifications
You must be signed in to change notification settings - Fork 44
feat: Selector for seg #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
fedorov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@fedorov please try again. |
|
I like this new feature, however I do worry that it may not be especially apparent to most users exactly what is happening. They may wonder what the difference is between individual segments (below in the toggles) and the series that they reside in (above in the dropdown), because that is not in my opinion immediately obvious from the user interface. Not sure on the best way to address this, but I think that we should at least label the part of the panel containing the segment with the word "Segments" or something like that. |
|
Also, if there are multiple series selected in the dropdown, should we show which segments belong to which series? |
|
@CPBridge those are good points, but I think this goes beyond the scope of the issue this PR aims to address. The idea is to have SEG selection to have the same features as ANN (and you can see how that looks in the screenshot here #307 (comment)). In my view, one of the issues we have with Slim interface is that it is disconnected from the DICOM model. Markus was convinced that the concept of "series" should be hidden from the users. While that might make sense when one has only slides, it becomes very difficult to manage in presence of image-derived series. I think we need to review the UI, across all types of DICOM data it handles, review how other tools expose those derived artifacts, and try to refine it. I don't think we should do it as part of this PR. |
|
@igoroctaviano it now remembers that the series is selected when I select the first one, but forgets it after I select the second one. |
I see, try again, please. |
|






Add SEG Series Selection and Toggling Support
Overview
This PR adds support for selection and toggling of SEG (Segmentation) series, replicating the functionality that already exists for ANN (bulk annotations). Users can now select specific SEG series from a dropdown and toggle visibility of all segments within the selected series.
Problem
Previously, SEG series only had individual segment visibility controls without the ability to:
This created an inconsistent user experience compared to ANN series, which already had these features.
Solution
Implemented comprehensive SEG series management functionality that mirrors the existing ANN implementation:
🎯 Series Selection Dropdown
👁️ Global Visibility Toggle
🔄 Series-Specific Filtering
Changes Made
📁 Files Modified
slim/src/components/SlideViewer/types.tsselectedSegmentationSeriesInstanceUID?: stringtoSlideViewerStateinterfaceslim/src/components/SlideViewer.tsxselectedSegmentationSeriesInstanceUID: undefinedto component statehandleSegmentationSeriesSelection()method that:getSegmentationMenu()method to include:SeriesInstanceUIDslim/src/components/SegmentList.tsxSwitchcomponent and eye icons from Ant DesignhandleVisibilityChange()method for global visibility control🧪 Testing
🎨 User Experience Improvements
Before
After
🔧 Technical Details
State Management
Series Grouping Logic
🚀 Impact
📋 Checklist