alarm: Long press to stop alarm

[vkareh]

This change prevents accidentally turning off alarm by ensuring that there is a deliberate long press, similar to resetting the Timer app.

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	383100B	320B
data	944B	0B
bss	22632B	0B

Run in InfiniEmu

[mark9064]

I haven't had a chance to test this with hardware since the ringing screen has been redesigned. Does the progress bar need to move at all? Maybe it could go between the time and the button in the blank space. Also if it looks a bit blocky (again I need to test), it will render more nicely if it is thinner since there will be fewer pixels to push.

[mark9064]

Especially with the bigger button, I think this is a good addition. Thanks for the contribution! The only suggestion I have is calculating the bar progress more consistently and making sure it's super clear to the user that they have to hold the button

[minacode]

Is the animation in the description still up to date? If not, can you please provide a new one? :)

I like the idea of a separate screen if the alarm goes off, but this PR is still very good for making sure that less alarms will be missed due to ghost touches.

[vkareh]

@minacode

Is the animation in the description still up to date? If not, can you please provide a new one? :)

I've just updated it

[minacode]

Thank you 🙂

Can we make one more design iteration?

Maybe you can put the bar on the top of the screen, make it a little slimmer and also maybe not orange? Or feel free to suggest something else if you have another idea. Let's just see if we can make it fit in better.

Another more free idea would be to have a red background with the time in the middle and a transparent circle around it that fills clockwise while pressing the screen.

[vkareh]

@minacode

Maybe you can put the bar on the top of the screen, make it a little slimmer and also maybe not orange? Or feel free to suggest something else if you have another idea. Let's just see if we can make it fit in better.

The orange bar is similar to the one in the timer reset button, so it's intended to keep it consistent/visible. However, I moved to bar to the top of the screen and made it a bit slimmer. What do you think?

Another more free idea would be to have a red background with the time in the middle and a transparent circle around it that fills clockwise while pressing the screen.

This seems like an unnecessary large change. This PR uses lv_bar, which is a native construct for this type of progress bar, and so has very little code/overhead.

[minacode]

Thank you 🙂
I like the new version and think it looks cleaner.

[tituscmd]

What if the stop button gradually loses saturation while it’s being pressed? The progress bar is helpful, but it might not be clear enough on its own that something’s actually happening when the button is being held down.

[vkareh]

@tituscmd

What if the stop button gradually loses saturation while it’s being pressed? The progress bar is helpful, but it might not be clear enough on its own that something’s actually happening when the button is being held down.

My first iteration had the bar as part of the button (similar to the timer), but with the finger on the button itself, I couldn't see anything happening.

[tituscmd]

The problem I'm seeing here is that, going from a single press button like before to a long press button now, the old version is visually indistinguishable to the new one, which might be confusing for new users. It would be helpful to include a visual cue, for example one could replace the icon on the button with text like 'Hold to stop'.

Gradually changing the button's color should also work for visibility, since the button is large enough that it wouldn’t be fully covered by a finger if held down.

[minacode]

Thinking about it, we need a sufficient visual hint either from the start ("hold to stop") or at least after a short touch didn't work. Otherwise people might just press repeatedly and wonder why the button doesn't work.

What do you all think about using "Hold to stop" on the button without any other animation to get the alarm protection part of this PR merged soon and then we have more time to think about cool visual hints?

[mark9064]

If you just tap it, the bar starts appearing immediately right? So there's feedback, and the eye sees motion so I guess it's reasonably clear it needs holding?

Changing the button colour might not look too good because it requires too much drawing to happen smoothly I think, but I guess we'd need to test

[minacode]

Ok, then I am fine with merging the current version :)

[mark9064]

Current visual design looks good to me, but I'd like to see code comments addressed (immediately rendering the bar on press and using total elapsed hold time rather than incrementing the position)

[vkareh]

Current visual design looks good to me, but I'd like to see code comments addressed (immediately rendering the bar on press and using total elapsed hold time rather than incrementing the position)

Done!

[mark9064]

Looks great to me! Haven't tested on hardware yet

Couple refactoring suggestions that hopefully will only take a few mins

[mark9064]

Looks great :)

[mark9064]

I've stuck it on 1.17 but IMO it's all good to be included in 1.16 if someone else reviews it in time