-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Dark App Launcher Tiles #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark App Launcher Tiles #2294
Conversation
Alarm: Simplify alarm alerting screen (InfiniTimeOrg#2211)
|
Build size and comparison to main:
|
|
The issue I see with this is it's a matter of preference: some people may prefer the aqua, and some may prefer this gray. I'm not sure if this would align with the vision, but a setting to change the theme would be nice, with options for the original color, this gray, maybe a red, and so on. |
|
I think we'd probably want to stick to one theme, as supporting multiple adds some extra overhead from a code maintenance perspective. I think it's nice that the colours are synchronised, though I don't feel super strongly |
|
As I found out in #2301 , the application launcher does track an enabled state for the app icons (for when the resources are missing for example). So nothing against changing the color, just mentioning that is should probably still allow seeing a disabled app icon. |
|
@JF002 Any chance you can chime in, I got interested in InfiniTime long after this colour was chosen so wondering if there's any history here (and therefore maybe reasons to change/not to change it) |
|
I'm not sure I remember how this specific color was chosen, to be honest. We used to have maintainers who took care of the UI (themes, colors, layout,..) but they are not around anymore. |
mark9064
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM to me then :)
|
I agree that using the theme here is the correct way to go. Changing the theme would be another discussion. |
|
Thank you! 🙂 |
You're very welcome! :) |
This is a simple PR to replace the aqua colored tiles in the app launcher with darker ones, going hand-in-hand with my #2292
This is most likely just up to taste, but I thought the cyan tiles were outdated since that color isn't used anywhere else, so I thought a darker color would match the current system theme better.
Let me know what you think!