Skip to content

Conversation

@yakov-olkhovskiy
Copy link

No description provided.

@github-actions
Copy link

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

@mark9064
Copy link
Member

I believe the current name is correct for the download, that resolves to a file while the change suggested here is a dead link. What problems are you having that are solved by this PR?

You've probably seen it already, but #2270 only got merged recently so perhaps you need to rebase/merge those changes in to your local version

@mark9064 mark9064 added the needs more info More information is needed label May 23, 2025
@yakov-olkhovskiy
Copy link
Author

@mark9064 I just cloned this repo and tried to build in dev container (windows VSCode) and it failed not finding nrf sdk, then I looked into /opt and found it under different name, made that change and it builds ok now.

@mark9064
Copy link
Member

mark9064 commented May 23, 2025

neroburner has done some investigation and you're definitely on the right track, he hopes to write some more about it here soon. thanks for the report :)

@NeroBurner
Copy link
Contributor

The upstream NRF-SDK download url and zip archive filename changed, which was fixed with #2270

But the archive contents stayed the same, with the "old" folder name

After #2270 we have basically the same docker-container as before the MR, but the GetNrfSdk function of the build.sh script is called again during firmware build time as the expected foldername for the SDK isn't the same as the zip filename:

[ ! -d "$TOOLS_DIR/$NRF_SDK_VER" ] && GetNrfSdk

[ ! -d "$TOOLS_DIR/$NRF_SDK_VER" ] && GetNrfSdk

Then during the build the buils.sh script tries to execute GetNrfSdk again, which fails as the files already exist:
https://github.com/InfiniTimeOrg/InfiniTime/actions/runs/15215211133/job/42804040210#step:5:41

replace /opt/nRF5_SDK_15.3.0_59ac345/components/802_15_4/api/HAL/hal_atomic.h? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL

@NeroBurner
Copy link
Contributor

created #2299 with a (hopefully) full fix

@mark9064
Copy link
Member

Should be fixed now :)

@mark9064 mark9064 closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs more info More information is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants