Music: Redesign Part 2 #2337
Music: Redesign Part 2 #2337
Conversation
Alarm: Simplify alarm alerting screen (InfiniTimeOrg#2211)
…oach to switching between skipping and volume buttons
|
Build size and comparison to main:
|
|
Latest commit makes the UI switch on reconnection much smoother, since we now force fetch the data and update the UI if we just reconnected - otherwise we only fetch new data if it changed. |
|
|
|
|
|
Looking good, @tituscmd! Thanks for your work on this! |
|
This PR should be ready for review from my side :) |
|
Ooh, what if the progress bar was blue? 
|
I personally like the gray and don't see any big improvement in terms of readability with a blue one. |
|
I'm of the belief that track info isn't needed on a watch or should be at least be minimized to a progress bar. The buttons could them be laid out in a way that would make them easier to press. Just my 2 cents. |
|
@0x0000ff That being said, I think it's more important at this point to get the UI merged so people can actually start using it when the next version of InfiniTime is released... More changes can always be made in the future. |
Not quite sure what you mean by this. Care to elaborate? |
Agreed. Should be all good to merge from my side I think. |
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
Looking good :)
Haven't tested locally or ran clang-tidy yet
Co-authored-by: mark9064 <30447455+mark9064@users.noreply.github.com>
…nto music_redesign_2
…nto music_redesign_2
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
Pretty much there I think :)
| #include "displayapp/icons/music/disc.c" | ||
| #include "displayapp/icons/music/disc_f_1.c" | ||
| #include "displayapp/icons/music/disc_f_2.c" |
There was a problem hiding this comment.
The disc icon files should be deleted as well. Though I'm a little (quite) sad to see it go... it does allow more functionality to fit in
There was a problem hiding this comment.
I'm also not particularly fond of getting rid of it, but it makes too much sense for usability 😔
| } | ||
|
|
||
| album = musicService.getAlbum(); | ||
| if (album.IsUpdated()) { |
There was a problem hiding this comment.
Album unused? If so we can remove it as a member
There was a problem hiding this comment.
Yeah I was wondering about that, should we try to include it in the UI somehow? Although I don't think ever seen it used.
There was a problem hiding this comment.
I don't think it's too important compared to the track title and artist so it probably doesn't justify the space. Especially as a lot of the time the field is probably blank (since podcasts/video content etc. don't really have an album)
There was a problem hiding this comment.
Yep, that's fair. I'll go ahead and remove it next time I'm available. Might take a few days because of the upcoming holidays.
There was a problem hiding this comment.
No rush, drop a message whenever :) happy holidays!
There was a problem hiding this comment.
Thanks, will do :)
Happy holidays to you as well!
|
|
||
| Widgets::PageIndicator pageIndicator = Widgets::PageIndicator(0, 2); | ||
| Utility::DirtyValue<bool> bleState {}; | ||
| Utility::DirtyValue<bool> bleRadioEnabled {}; |
6 participants
Hey everybody,
Since creating PR #2292 and introducing a small little redesign of the music app, I've had some more time on my hands and finally came around to creating a better version of it.
I've moved the artist and track name up a bit to add a new progress bar that shows the progress of the song you're listening to, with the time that has passed shown on the left and the time remaining shown on the right.
Sadly, I've had to remove (comment out) the disc animation in the top right because of space issues. If anyone is especially fond of the disc I'm sure space can be made to fit it back in. It is definitely not a final decision by me, hence why it's only commented out and not removed altogether.
But now that I've temporarily removed the disc animation, the top of the screen seemed quite empty to me. And after some thinking and digging through the code, I stumbled upon these lines of code in the Music.cpp:
And so I thought "why not do that?" and I added an indicator text at the top telling you if you are connected via bluetooth. Please share your opinion on this.
Finally, here are some pictures of it all:
