Skip to content

Split oversized SPI reads #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mark9064 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Split oversized SPI reads #2391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/drivers/SpiMaster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ void SpiMaster::OnStartedEvent() {
}

void SpiMaster::PrepareTx(const uint32_t bufferAddress, const size_t size) {
ASSERT(size < 256);
spiBaseAddress->TXD.PTR = bufferAddress;
spiBaseAddress->TXD.MAXCNT = size;
spiBaseAddress->TXD.LIST = 0;
Expand All @@ -171,6 +172,7 @@ void SpiMaster::PrepareTx(const uint32_t bufferAddress, const size_t size) {
}

void SpiMaster::PrepareRx(const uint32_t bufferAddress, const size_t size) {
ASSERT(size < 256);
spiBaseAddress->TXD.PTR = 0;
spiBaseAddress->TXD.MAXCNT = 0;
spiBaseAddress->TXD.LIST = 0;
Expand Down Expand Up @@ -240,12 +242,17 @@ bool SpiMaster::Read(uint8_t pinCsn, uint8_t* cmd, size_t cmdSize, uint8_t* data
spiBaseAddress->TASKS_START = 1;
while (spiBaseAddress->EVENTS_END == 0)
;
while (dataSize > 0) {
size_t readSize = std::min(dataSize, 255U);
PrepareRx((uint32_t) data, readSize);
spiBaseAddress->TASKS_START = 1;

PrepareRx((uint32_t) data, dataSize);
spiBaseAddress->TASKS_START = 1;

while (spiBaseAddress->EVENTS_END == 0)
;
while (spiBaseAddress->EVENTS_END == 0) {
;
}
data += readSize;
dataSize -= readSize;
}
nrf_gpio_pin_set(this->pinCsn);

xSemaphoreGive(mutex);
Expand Down