Skip to content

Disable LowerWrist during sleep mode #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kieranc wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Disable LowerWrist during sleep mode #2415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
360cfbc
Maybe it's this easy?
kieranc Feb 8, 2026
09cfb6e
There's always an oops
kieranc Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/systemtask/SystemTask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ void SystemTask::UpdateMotion() {
}
}
if (settingsController.isWakeUpModeOn(Pinetime::Controllers::Settings::WakeUpMode::LowerWrist) && state == SystemTaskState::Running &&
motionController.ShouldLowerSleep()) {
motionController.ShouldLowerSleep() && (settingsController.GetNotificationStatus() != Controllers::Settings::Notification::Sleep)) {
Copy link
Member

@mark9064 mark9064 Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move into the if block above instead (it already checks the condition)

Copy link
Contributor

@NeroBurner NeroBurner Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which line do you mean? Could you clarify?

Copy link
Member

@mark9064 mark9064 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L458 already checks (settingsController.GetNotificationStatus() != Controllers::Settings::Notification::Sleep)
So the lower wrist check can move to L465 and the extra check of the notification status is not needed

GoToSleep();
}
}
Expand Down