Skip to content

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Nov 18, 2024

Closes #

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 changed the title wip feat: respect iox::column_type::field metadata when mapping query results into values Nov 19, 2024
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Nov 19, 2024
@bednar bednar marked this pull request as draft November 19, 2024 12:00
@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (6d1607f) to head (03fd834).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...fluxdb/v3/client/internal/NanosecondConverter.java 92.85% 0 Missing and 2 partials ⚠️
...nfluxdb/v3/client/internal/InfluxDBClientImpl.java 97.14% 0 Missing and 1 partial ⚠️
.../v3/client/internal/VectorSchemaRootConverter.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   89.59%   90.10%   +0.51%     
==========================================
  Files          17       17              
  Lines         903      970      +67     
  Branches      137      148      +11     
==========================================
+ Hits          809      874      +65     
  Misses         38       38              
- Partials       56       58       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bednar bednar marked this pull request as ready for review November 21, 2024 09:50
@bednar bednar marked this pull request as draft November 21, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants