test: adds integration test for handling flightRuntimeExceptions. #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 89.71% 89.71%
=======================================
Files 18 18
Lines 963 963
Branches 150 150
=======================================
Hits 864 864
Misses 39 39
Partials 60 60 ☔ View full report in Codecov by Sentry. |
bednar
approved these changes
Dec 9, 2024
Member
bednar
left a comment
bednar
left a comment
There was a problem hiding this comment.
@karel-rehor thanks for PR 👍
LGTM 🚀
| Motivated by EAR 5718, useful exception INVALID_ARGUMENT was being masked by | ||
| INTERNAL: http2 exception - Header size exceeded max allowed size (10240). | ||
| */ | ||
| public String makeLengthyTag(final int length, final int maxPartLength, final byte separator) { |
Member
There was a problem hiding this comment.
Make this method private and move it to the bottom of the file. Public methods should come first, followed by private methods.
Suggested change
| public String makeLengthyTag(final int length, final int maxPartLength, final byte separator) { | |
| private String makeLengthyTag(final int length, final int maxPartLength, final byte separator) { |
Contributor
Author
There was a problem hiding this comment.
Updated as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/influxdata/EAR/issues/5718
Proposed Changes
Adds a new integration test in
ITQueryWriteto verify that errors are returned correctly, or more specifically that theHttp2Exception: Header size exceededexception no longer preempts more meaningful exceptions.Checklist