Skip to content

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Nov 6, 2025

Proposed Changes

To avoid having org.apache.arrow.memory.BaseAllocator throw IllegalStateExceptions this adds ensures that FlightStream is closed correctly.

In FlightSqlClient

  • In the FlightSqlIterator ensure FlightStream.close() is called
  • One E2E tests covers the first solution.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.48%. Comparing base (240309c) to head (dbc6f66).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   87.47%   87.48%           
=======================================
  Files          20       20           
  Lines        1261     1262    +1     
  Branches      204      204           
=======================================
+ Hits         1103     1104    +1     
  Misses         74       74           
  Partials       84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karel-rehor karel-rehor marked this pull request as ready for review November 7, 2025 16:03
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

only: main
only:
- main
- fix/arrowBaseAllocatorMemoryLeak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to keep this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The Snapshot was deployed last night for customer testing. I verified it this morning. I'll revert it.

@karel-rehor karel-rehor merged commit 6cf278f into main Nov 11, 2025
9 checks passed
@karel-rehor karel-rehor deleted the fix/arrowBaseAllocatorMemoryLeak branch November 11, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants