-
Notifications
You must be signed in to change notification settings - Fork 8
fix: arrow BaseAllocator is reporting memory leaks #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage 87.47% 87.48%
=======================================
Files 20 20
Lines 1261 1262 +1
Branches 204 204
=======================================
+ Hits 1103 1104 +1
Misses 74 74
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/main/java/com/influxdb/v3/client/internal/FlightSqlClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/influxdb/v3/client/internal/FlightSqlClient.java
Outdated
Show resolved
Hide resolved
…sing FlightStream.
bednar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
jansimonb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 👍
.circleci/config.yml
Outdated
| only: main | ||
| only: | ||
| - main | ||
| - fix/arrowBaseAllocatorMemoryLeak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to keep this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The Snapshot was deployed last night for customer testing. I verified it this morning. I'll revert it.
Proposed Changes
To avoid having
org.apache.arrow.memory.BaseAllocatorthrowIllegalStateExceptions this adds ensures thatFlightStreamis closed correctly.In
FlightSqlClientFlightSqlIteratorensureFlightStream.close()is calledChecklist