-
Notifications
You must be signed in to change notification settings - Fork 202
[Pattern Draft] Managing capacity for reviewing contributions #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
1deb38d
6cc70c2
e357e1f
0762eae
ca9941f
94a9ac6
1f5eec4
124922f
3502897
47ef2ce
f4bdb57
d9d5e28
17b0f76
a9382a1
d185cf6
827de52
cc2aa4b
58521a7
facb787
3e0bb1c
adb7cc0
40b2595
eb957b2
34ca968
36465d6
f2d0043
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| ## Title | ||
|
|
||
| Managing capacity for reviewing contributions | ||
|
|
||
| ## Patlet | ||
|
|
||
| Reviewing InnerSource contributions takes time and effort. This should be reflected in capacity planning, especially for larger contributions. Expectations and available capacity should be transparent so that contributors understand when their contributions will be reviewed and released. | ||
spier marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Problem | ||
|
|
||
| Large InnerSource contributions are causing delays to other work in the team and/or contributions are taking longer to be released than expected. Reviewing contributions may be significant invisible work, not tracked in a team's agile development process. | ||
spier marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Story | ||
|
|
||
| The BBC's connected TV application are built by a number of teams, each with different areas of responsibility. They work on each other's areas of the codebase via InnerSource on a regular basis. | ||
spier marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| The team responsible for the build process for the JavaScript bundles received a major pull request, changing how dependencies were bundled. This PR introduced a new build time dependency, a new structure to the deployed JavaScript bundles, and touched 503 files, with 6,699 lines of code added and 2,828 lines of code deleted. A contribution of this size required significant time to code review, test, and ensure the team understood the new tooling and structure introduced. Normally, InnerSource contributions would be reviewed ad-hoc, but the team estimated that this review process would take days rather than hours. Reviewing this PR would have delayed the team's other work, so the team raised this with the team lead, delivery manager, and product manager, to prioritize this work against other work. Time was set aside to review this contribution at future date. | ||
tsadler1988 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| This process was formalized in the team: | ||
|
|
||
| * Larger contributions have a ticket created on the team's backlog and included in prioritization discussion alongside other tickets. The contributor will be informed of the priority call and given an estimate as to when it will be reviewed and released. | ||
spier marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
spier marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * Smaller contributions can still be reviewed ad-hoc. | ||
|
|
||
| ## Context | ||
|
|
||
| Maintainers of a successful InnerSource project are finding it difficult to review contributions, especially large contributions. They do not want to disrupt their team's other work, but also want to support contributions by reviewing/releasing them in a timely fashion. | ||
|
|
||
| ## Forces | ||
|
|
||
| * Contributors expect timely feedback on their contributions | ||
| * Maintaining team are expected to deliver other work alongside reviewing contributions | ||
| * Missing communication between contributors and maintainers on expectations/lead time for contributions to be reviewed/released | ||
| * Tension in prioritizing InnerSource contributions against other work | ||
|
|
||
| ## Solutions | ||
spier marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| * Reviewing larger contributions is tracked in the team's ticketing system/bug tracker (e.g. Jira, GitHub issues) | ||
| * Maintaining team is given time to review larger contributions in team capacity planning | ||
spier marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * Reviewing contributions is prioritized against other work (e.g. in sprint planning) | ||
| * Maintainers communicate their capacity for reviewing contributions, the priority of contributions, and an estimate of when a contribution will be reviewed/released | ||
| * Maintaining team has a service level objective (SLO) (e.g. 2 working days) for contributions receiving initial feedback | ||
|
||
|
|
||
| ## Resulting Context | ||
|
|
||
| Maintaining team understands the overhead of reviewing large contributions and is given capacity to do so. Project manager and product managers are better able to plan, estimate, and track other work in the team by accounting for the time taken to review InnerSource contributions. Contributors understand when their contribution will be reviewed and released, and how long before the maintainers will provide initial feedback. | ||
|
||
|
|
||
| ## Known Instances | ||
|
|
||
| BBC iPlayer & Sounds | ||
spier marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ## Status | ||
|
|
||
| Initial | ||
|
|
||
| ## Author(s) | ||
|
|
||
| Tom Sadler | ||
|
|
||
| ## Acknowledgments | ||
|
|
||
| Clare Dillon | ||
Uh oh!
There was an error while loading. Please reload this page.