Update recently updated tests to run properly when no fp64#2273
Merged
antonwolfy merged 4 commits intomasterfrom Jan 22, 2025
Merged
Update recently updated tests to run properly when no fp64#2273antonwolfy merged 4 commits intomasterfrom
antonwolfy merged 4 commits intomasterfrom
Conversation
floating dtypes in sort and argsort tests
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
vlad-perevezentsev
approved these changes
Jan 22, 2025
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM!
Thank you @antonwolfy
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_18 ran successfully. |
github-actions bot
added a commit
that referenced
this pull request
Jan 22, 2025
Some of the tests which were updated by latest PRs don't work properly when running on a device without fp64 support. The PR is intended to resolve that and to implement proper check of the resulting arrays for impacted tests. 451c2b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the tests which were updated by latest PRs don't work properly when running on a device without fp64 support.
The PR is intended to resolve that and to implement proper check of the resulting arrays for impacted tests.