Add missing message-id to step which modifies PR comment#2292
Merged
antonwolfy merged 1 commit intomasterfrom Feb 3, 2025
Merged
Add missing message-id to step which modifies PR comment#2292antonwolfy merged 1 commit intomasterfrom
message-id to step which modifies PR comment#2292antonwolfy merged 1 commit intomasterfrom
Conversation
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
antonwolfy
changed the title
message-id to step which modifies PR comment
vlad-perevezentsev
approved these changes
Feb 3, 2025
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_16 ran successfully. |
github-actions bot
added a commit
that referenced
this pull request
Feb 3, 2025
`message-id` was added per #2271 to `mshick/add-pr-comment` steps in GitHub workflows, but one of the places was missing. The PR proposes to resolve that and to set the expected id, otherwise the affected step couldn't find the PR comment to update it (since `message-id: add-pr-comment` which it built by default differs). 2ac196c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message-idwas added per #2271 tomshick/add-pr-commentsteps in GitHub workflows, but one of the places was missing.The PR proposes to resolve that and to set the expected id, otherwise the affected step couldn't find the PR comment to update it (since
message-id: add-pr-commentwhich it built by default differs).