Deprecate setting the strides attribute of dpnp array#2732
Closed
vlad-perevezentsev wants to merge 3 commits intomasterfrom
Closed
Deprecate setting the strides attribute of dpnp array#2732vlad-perevezentsev wants to merge 3 commits intomasterfrom
vlad-perevezentsev wants to merge 3 commits intomasterfrom
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_56 ran successfully. |
Collaborator
antonwolfy
reviewed
Jan 20, 2026
| def test_set_strides_deprecated(self): | ||
| x = dpnp.eye(2) | ||
| with pytest.warns(DeprecationWarning, match="Setting the strides"): | ||
| setattr(x, "strides", x.strides) |
Contributor
There was a problem hiding this comment.
We need some validation the strides really changed
Contributor
Author
|
After investigation setting strides is already not supported in dpnp:
so no additional deprecation logic is needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates setting the strides attribute of dpnp array (following NumPy 2.4)