Extend ._tensor_impl with remaining functions used by dpnp#2758
Extend ._tensor_impl with remaining functions used by dpnp#2758vlad-perevezentsev wants to merge 41 commits intoinclude-dpctl-tensorfrom
._tensor_impl with remaining functions used by dpnp#2758Conversation
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2758/index.html |
|
Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_49 ran successfully. |
dpctl_ext/tensor/libtensor/include/kernels/integer_advanced_indexing.hpp
Show resolved
Hide resolved
| from dpctl_ext.tensor._ctors import ( | ||
| full, | ||
| tril, | ||
| triu, | ||
| ) | ||
| from dpctl_ext.tensor._indexing_functions import ( | ||
| put, | ||
| take, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| "full", | ||
| "put", | ||
| "take", | ||
| "tril", | ||
| "triu", | ||
| ] |
There was a problem hiding this comment.
if we're adding these functions in, should we start adding dpctl test suite as well?
Or would you rather start reusing the functions in dpnp and relying on dpnp tests?
I think it's sensible to have the two test suites and merge later if possible, but it's just a choice we have to make
ndgrigorian
left a comment
There was a problem hiding this comment.
I don't see much else that I would change, looks like you've looked over includes. Only question from my side is the test suite
@antonwolfy if you have any thoughts you should add them but this LGTM
This PR extends
_tensor_implindpctl_ext.tensorwith the remaining functions that are explicitly used indpnpimplementations (_take,_full_usm_ndarray,_zeros_usm_ndarray,_triu) enabling a complete switch todpctl_ext.tensor._tensor_implinstead ofdpctl.tensor._tensor_implIt also adds
take(),put(),full(),tril()andtriu()todpctl_ext.tensorand updates the corresponding dpnp functions to use these implementations internally