Skip to content

change import order to avoid circular dependency #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vtavana merged 1 commit into from
Apr 11, 2025
Merged

change import order to avoid circular dependency #156

vtavana merged 1 commit into from
Apr 11, 2025

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Apr 10, 2025 •
edited
Loading

change import order in mkl_fft/__ini__.py to avoid circular dependency that occurs in building wheel

@vtavana vtavana self-assigned this Apr 10, 2025
@ekomarova
Copy link
Collaborator

ekomarova commented Apr 11, 2025

I will test this change in internal CI and let you know.

@ekomarova
Copy link
Collaborator

ekomarova commented Apr 11, 2025

It works

@vtavana vtavana marked this pull request as ready for review April 11, 2025 11:42
ekomarova
ekomarova approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@ekomarova ekomarova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good for me and it completely fixes the issue with import

@vtavana vtavana merged commit ba40a93 into master Apr 11, 2025
49 checks passed
@vtavana vtavana deleted the circular-dep branch April 11, 2025 11:52
@vtavana vtavana mentioned this pull request Apr 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekomarova ekomarova ekomarova approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@xaleryb xaleryb Awaiting requested review from xaleryb xaleryb is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana @ekomarova