fix: Improve edit processing #2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Completely nullifies issue of writing to SET between processing submission and processing completion - Leads to larger memory footprint, but that is acceptable - Leads to performance improvement in processing as there is no need to perform any multi-threading protection operations - Fixes #1861 - Fixes #2074 (gonna go ahead and say it does, this is really the only thing I can think of to do with the issue, and it's super rare anyway (never replicated by anyone else))
Member
|
This has some conflicts with #2181 |
Contributor
I know our memory usage is already pretty good and can take a hit but I am curious as to how much more memory this uses. Did you have an estimate? |
Member
Author
0.5 to maybe 4 Mbit a chunk I guess (so 0.1 to 0.5 MB) |
MattBDev
approved these changes
May 30, 2023
SirYwell
requested changes
May 30, 2023
Member
SirYwell
left a comment
SirYwell
left a comment
There was a problem hiding this comment.
found a typo but looks good otherwise
worldedit-core/src/main/java/com/fastasyncworldedit/core/queue/IChunkSet.java
Outdated
Show resolved
Hide resolved
dordsor21
force-pushed
the
fix/copy-set-before-process
branch
from
4a0c7b2 to
a5193ed
Compare
SirYwell
approved these changes
May 31, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a copy of SET chunk before processing