Return air instead of __reserved__ when reading non-cuboid clipboard#3071
Return air instead of __reserved__ when reading non-cuboid clipboard#3071
Conversation
|
Can we potentially add a flag somewhere for allowing the reserved? If we set a clipboard within FAWE it might be wanted not to set outside the original copy region, but still set air within. Presumably this is also an issue for the other FAWE implementations as well? |
This just mirrors the behavior of WE. Manually checking if the point is in the region when needed sounds more appropriate.
It seems like |
We won't necessarily have the selection when pasting - it could have changed between the copy and paste, or have been made before a restart
memory optimized doesn't "store" air so I believe would assume reserved is just normal air. CPU optimized is potentially problematic as it'd read a char of 0 from the array |
Hm, that's an interesting scenario. I guess |
Yeah potentially some more thought to that. I do think it's a feature to allow "non-rectangular" clipboards to have air without overwriting a selection |
Overview
Fixes #3065
Description
Returning the
__reserved__block state results in clipboards containing that block state, means they can't be loaded by other tools correctly and FAWE won't place air correctly.