-
-
Notifications
You must be signed in to change notification settings - Fork 306
fix: don't write structure void blocks in minecraft structure #3092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| } | ||
|
|
||
| // Blocks | ||
| LinListTag.Builder<@org.jetbrains.annotations.NotNull LinCompoundTag> blocks = LinListTag.builder(LinTagType.compoundTag()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this top javax while we're here I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Like I said on Discord, I wonder if it's an idea to add a switch to allow/disallow structure void to be pasted - I can see it being useful to know where they are |
|
By default, Structure Void blocks should be pasted because they are simply part of the structure / schematic, I think. In vanilla, Maybe a paste command flag for FAWE would be an idea, which would paste AIR like in Vanilla and leave out |
|
Just ran into this issue saving Minecraft structure schematics for my plugin, would appreciate this getting merged! |
… add option to ignore structure void blocks on paste
ead07a3 to
54670fb
Compare
|
Should be fine now ig. When loading Structure File clipboards / schematics the resulting clipboard is filled with structure void blocks, so that every clipboard position actually has a block. Known blocks are overriding the structure void blocks. Pasting without any arguments pastes the clipboard including the structure void blocks (suitable for knowing where they are of if the structure needs to be changed). Passing the -v switch (e.g. |


Overview
Fixes #3090