feat: fully implement Player#sendFakeBlock#3367
Open
Timongcraft wants to merge 5 commits intoIntellectualSites:mainfrom
Open
feat: fully implement Player#sendFakeBlock#3367Timongcraft wants to merge 5 commits intoIntellectualSites:mainfrom
Timongcraft wants to merge 5 commits intoIntellectualSites:mainfrom
Conversation
Timongcraft
force-pushed
the
feat/fully-impl-fake-block
branch
from
1909470 to
5fbd4fd
Compare
dordsor21
requested changes
Nov 30, 2025
worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitPlayer.java
Outdated
Show resolved
Hide resolved
dordsor21
approved these changes
Dec 14, 2025
Timongcraft
force-pushed
the
feat/fully-impl-fake-block
branch
2 times, most recently
from
07d54e1 to
10b81d6
Compare
-> fix: rare exception when using CraftBlockEntityState#getSnapshotNBT async (with latest 1.21.10 Paper builds?)
-> decupled from fake block handling chore: up deprecation version
Timongcraft
force-pushed
the
feat/fully-impl-fake-block
branch
from
10b81d6 to
751156d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the
Player#sendFakeBlockimplementation in Bukkit to support non structure-blocks (used by the CUI).Description
Replaces the structure block specific implementation with a generic implementation to allow API users to send fake blocks containing NBT such as player heads, banners etc.
Submitter Checklist
- [ ] New public fields and methods are annotated with@since TODO.Notes
Tested on Paper 1.21.10-123-ver/1.21.10@659e965 and 1.21.11-39-main@e5e2c50