Improve BlendBall performance using custom Filter #3421
+94
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description
BlendBall is implemented acting on a cube, applying a block-by-block action with no dependencies between these actions. Significant performance overhead is caused by the
EditSession#getBlock(...)indirection, going through the extent stack and the chunk caching mechanism. On top of that, for larger radii, we still process each block sequentially instead of making use of multiple threads.By implementing a custom Filter, we lower the overhead of accessing blocks as well as easily introducing parallelism.
Submitter Checklist
@since TODO.