Skip to content

Conversation

@Langomatisch
Copy link

Overview

I find it difficult to work with PlotModificationManager#autoMerge because the code is full of code-duplications.

This way its more readable and needs to be less maintained.

Description

I removed all code-duplications out of that method.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@Langomatisch Langomatisch requested a review from a team as a code owner May 3, 2023 09:07
@github-actions github-actions bot added the Bugfix This PR fixes a bug label May 3, 2023
@TheMeinerLP
Copy link
Member

Have you tested it ?

@Langomatisch
Copy link
Author

Have you tested it ?

Yes i have tested it on a local server

@TheMeinerLP
Copy link
Member

If you have some time over and be cool when you can add it for this an unit test 👍🏻

@Langomatisch
Copy link
Author

Sure thing! I will do that in the evening :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants