-
-
Notifications
You must be signed in to change notification settings - Fork 921
fix: correct tab completion for /plot flag set <flag> <value>
#4698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: correct tab completion for /plot flag set <flag> <value>
#4698
Conversation
PierreSchwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works
|
the tabcompletion should probably get a small refactor - if you want to, you can adjust those small things:
|
|
Still new to this so I just did the third suggestion, should be fine like that. |
| .map(value -> new Command(null, false, value, "", RequiredType.NONE, null) { | ||
| }).collect(Collectors.toList()); | ||
| } else if (Arrays.asList("set", "add", "remove", "delete", "info") | ||
| } else if (Arrays.asList("set", "s", "add", "a", "remove", "r", "delete", "info", "i") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'd like to see these extracted to static final Collections.immutableSet at the class level - this would be best practices for Java. The args.length == # should be moved -- it is unlikely for these operations to be reordered
Overview
Fixes #3028
Description
This PR fixes the incorrect tab completion behavior for the command
/plot flag set <flag> <value>Submitter Checklist
@since TODO.