script for generating CTTC results and some bug fixes #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chyomin06
reviewed
Oct 23, 2025
| dec_d = { | ||
| "file_name": dec_seq["file_names"][e], | ||
| "file_origin": d[e]["file_name"], | ||
| "file_origin": d[0]["file_name"], |
Collaborator
There was a problem hiding this comment.
@jianwensong Is this change necessary?
I forgot which case was, but I remeber there was a case we still need access with an index.
Would you please confirm this?
Contributor
Author
There was a problem hiding this comment.
I think it is necessary (at least under current remote inference settings). When the batch size is one, each 'd' enumerated from the 'dataloader' is a list containing one dictionary. If we set it to d[e], remote inference will result in an error. I think only the case where batch size is larger than one may need access this index. But I am not sure whether remote inference always uses batch size 1 or if it supports larger batch sizes.
fracape
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.