Skip to content

Conversation

@carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jan 13, 2026

Changelog

- description: |
    Add `SerialiseAsRawBytes Word64` instance to `Cardano.Api.Serialise.Raw`
    Add `Text reexport to `Cardano.Api.Pretty. Add `DecoderError` reexport to `Cardano.Api.Serialise.Cbor`
    gRPC: Add tracing datatypes
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
# uncomment at least one main project this PR is associated with
  projects:
   - cardano-api
  # - cardano-api-gen
   - cardano-rpc
  # - cardano-wasm

Context

The changes are integrated in IntersectMBO/cardano-node#6273

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this Jan 13, 2026
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-rpc-tracing branch from 49a5b3e to 02fcb8c Compare January 16, 2026 17:16
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-rpc-tracing branch 3 times, most recently from e02c28e to a9f1a86 Compare January 20, 2026 11:31
@carbolymer carbolymer changed the title cardano-rpc | Add tracing types gRPC: Add tracing types Jan 20, 2026
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-rpc-tracing branch 3 times, most recently from 20c16c7 to 9366523 Compare January 20, 2026 12:15
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-rpc-tracing branch from 9366523 to 9539675 Compare January 20, 2026 12:30
@carbolymer carbolymer changed the title gRPC: Add tracing types gRPC: Add tracing datatypes Jan 20, 2026
@carbolymer carbolymer marked this pull request as ready for review January 20, 2026 12:59
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly opposed to the default language extensions. Other than that LGTM.

common project-config
default-language: Haskell2010
default-extensions:
BangPatterns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer per module explicit language extensions at the top of the module.

deserialiseFromRawBytes AsWord64 = deserialiseWord

-- | Deserialise any length number.
deserialiseWord
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no haskell library that does this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants