-
Notifications
You must be signed in to change notification settings - Fork 27
gRPC: Add tracing datatypes #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
49a5b3e to
02fcb8c
Compare
e02c28e to
a9f1a86
Compare
20c16c7 to
9366523
Compare
9366523 to
9539675
Compare
Jimbo4350
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strongly opposed to the default language extensions. Other than that LGTM.
| common project-config | ||
| default-language: Haskell2010 | ||
| default-extensions: | ||
| BangPatterns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer per module explicit language extensions at the top of the module.
| deserialiseFromRawBytes AsWord64 = deserialiseWord | ||
|
|
||
| -- | Deserialise any length number. | ||
| deserialiseWord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no haskell library that does this?
Changelog
Context
The changes are integrated in IntersectMBO/cardano-node#6273
Checklist