Remove requirement of "current treasury value" for transactions #1322
+59
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
requested review from
Jimbo4350,
carbolymer and
newhoggy
as code owners
Jimbo4350
requested changes
Jan 16, 2026
| , voteFiles :: ![(VoteFile In, Maybe (ScriptRequirements Exp.VoterItem))] | ||
| , proposalFiles :: ![(ProposalFile In, Maybe (ScriptRequirements Exp.ProposalItem))] | ||
| , currentTreasuryValueAndDonation :: !(Maybe (TxCurrentTreasuryValue, TxTreasuryDonation)) | ||
| , currentTreasuryValueAndDonation :: !(Maybe (Maybe TxCurrentTreasuryValue, TxTreasuryDonation)) |
Contributor
There was a problem hiding this comment.
Rather than having a nested Maybe convert it to a separate field instead.
Contributor
Author
There was a problem hiding this comment.
I can do that, but that would be lifting an additional restriction: that you can't have TxCurrentTreasuryValue without a TxTreasuryDonation. It wouldn't be equivalent
Contributor
Author
There was a problem hiding this comment.
Hm, actually, it may be that we can lift that restriction too, @lehins says they are completely independent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
See #1149
How to trust this PR
Ensure that only the specified restriction was lifted and in the appropriate places. Ensure this is the right thing to do. Confirm I interpreted this message correctly: https://discord.com/channels/1136727663583698984/1239888777015590913/1364244737602879498
Checklist