Allow unstable error messages in tests #3280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoura
force-pushed
the
allow_unstable_err_messages
branch
2 times, most recently
from
4cbece3 to
f87bc51
Compare
Removes the unused 'topology' input from regression workflows and scripts. Introduces a new 'allow_unstable_error_msgs' boolean input to control whether unstable error messages are allowed in tests. Updates environment variable handling and Python configuration to support this option.
Introduce `allow_unstable_error_messages` context manager in `common.py` to handle assertion errors for unstable error messages across different node/CLI versions. Refactor all test files to use this context manager, replacing direct assertions on error messages. This allows for temporarily ignoring specific error message checks when testing new features.
mkoura
force-pushed
the
allow_unstable_err_messages
branch
from
f87bc51 to
587e640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.