refactor(tests): fix tx unbalanced test example value #3283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the test to not use an in bounds Lovelace amount as an hypothesis example. Refactored the test for out-of-bounds Lovelace amounts to use pytest.raises for exception handling instead of try/except. Updated parameter names for clarity and removed redundant error string logic.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors a property-based test for out-of-bounds Lovelace amounts in transaction building. The changes improve test clarity by removing an invalid hypothesis example and modernizing exception handling.
Changes:
- Removed the
@hypothesis.example(change_amount=2_000_000)decorator which incorrectly used an in-bounds value - Refactored exception handling from try/except to pytest.raises context manager
- Renamed parameter from
change_amounttoamountfor consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the test to not use an in bounds Lovelace amount as an hypothesis example.
Refactored the test for out-of-bounds Lovelace amounts to use pytest.raises for exception handling instead of try/except. Updated parameter names for clarity and removed redundant error string logic.