feat(cli): add tests for cardano-cli ping tip and version
#3284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for new functionality of the cardano-cli ping command, specifically testing the --tip and --query-versions flags. It also registers a known issue related to version compatibility errors.
Changes:
- Added
test_ping_tipto verify querying blockchain tip usingcardano-cli pingwith TCP host/port connection - Added
test_ping_versionto verify querying node versions usingcardano-cli ping, with error handling for knownUnknownVersionInRspissue - Registered
network_5281issue blocker for tracking theUnknownVersionInRsperror in version-compatible CLI/node pairs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cardano_node_tests/tests/test_cli.py | Adds two new test methods to TestPing class for testing tip and version query functionality |
| cardano_node_tests/tests/issues.py | Registers network issue #5281 as a blocker for tracking known version query compatibility issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add `test_ping_tip` to verify querying the tip using `cardano-cli ping` with host and port. - Add `test_ping_version` to check querying versions and handle `UnknownVersionInRsp` error, referencing issue IntersectMBO/ouroboros-network#5281. - Register new issue blocker for network#5281 in `issues.py`.
mkoura
force-pushed
the
add_ping_query_tests
branch
from
e3af40d to
4275847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_ping_tipto verify querying the tip usingcardano-cli pingwith host and port.test_ping_versionto check querying versions and handleUnknownVersionInRsperror, referencing issueUnknownVersionInRspfromping --query-versionsfor compatible version of cli and node ouroboros-network#5281.issues.py.