refactor(era): update era handling and naming for latest #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mkoura
commented
Jan 15, 2026
mkoura
commented
- Remove DEFAULT_CLUSTER_ERA from regression.sh and simplify era logic.
- Update handling of CLUSTER_ERA and TESTNET_VARIANT in regression.sh.
- Clarify test descriptions for default/explicit tx era in test_tx_basic.py.
- Fix skip logic in test_tx_negative.py to use era names.
- Update versions.py:
- Set CONWAY to 10, add DIJKSTRA as 12.
- Set DEFAULT_CLUSTER_ERA and DEFAULT_TX_ERA to CONWAY.
- Set LAST_KNOWN_ERA to 11.
- Expand MAP for protocol version to era name mapping.
- Add comments for clarity on latest era and mapping.
- Remove DEFAULT_CLUSTER_ERA from regression.sh and simplify era logic. - Update handling of CLUSTER_ERA and TESTNET_VARIANT in regression.sh. - Clarify test descriptions for default/explicit tx era in test_tx_basic.py. - Fix skip logic in test_tx_negative.py to use era names. - Update versions.py: - Set CONWAY to 10, add DIJKSTRA as 12. - Set DEFAULT_CLUSTER_ERA and DEFAULT_TX_ERA to CONWAY. - Set LAST_KNOWN_ERA to 11. - Expand MAP for protocol version to era name mapping. - Add comments for clarity on latest era and mapping.
mkoura
force-pushed
the
era_handling_update
branch
from
b191921 to
f639978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.