Skip to content

Update messages desoutter tightening library #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PTKu merged 2 commits into from
Dec 15, 2025
Merged

Update messages desoutter tightening library #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
387e0b0
Create draft PR for #936
TomKovac Dec 15, 2025
d26eed7
Refactor code structure for improved readability and maintainability
TomKovac Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 15 additions & 31 deletions src/components.desoutter.tightening/ctrl/src/CVIC_II/AxoCVIC_II.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
THIS.CallTimers(FALSE);
_progress := 300;
END_IF;

// Reset running: waiting for 'Failed' flag to be reseted.
IF _progress = 300 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#500, eAxoMessageCategory#Warning);
Expand All @@ -673,7 +673,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 301;
END_IF;
END_IF;

// Reset running: waiting for 'InCycle' flag to be reseted.
IF _progress = 301 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#501, eAxoMessageCategory#Warning);
Expand All @@ -684,7 +684,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 302;
END_IF;
END_IF;

// Reset running: waiting for the device to be Ready.
IF _progress = 302 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#502, eAxoMessageCategory#Warning);
Expand All @@ -695,7 +695,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 303;
END_IF;
END_IF;

// Reset finished.
IF _progress = 303 THEN
Outputs.Control.SpindleValidation := FALSE;
Outputs.Control.StartCycle := FALSE;
Expand Down Expand Up @@ -754,8 +754,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
THIS.CallTimers(FALSE);
_progress := 310;
END_IF;

//Set program
// Set screwing program running: waiting for the program number is mirrored back.
IF _progress = 310 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#510, eAxoMessageCategory#Warning);
Expand All @@ -770,7 +769,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 311;
END_IF;
END_IF;

// Set screwing program finished.
IF _progress = 311 THEN
SetScrewingProgramTask.DoneWhen(TRUE);
_progress := 0;
Expand Down Expand Up @@ -821,7 +820,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 320;
END_IF;

//Reset results
// Screwing running: reseting the previous results.
IF _progress = 320 THEN
Outputs.Control.SpindleValidation := FALSE;
Outputs.Control.Reset := FALSE;
Expand All @@ -835,8 +834,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
THIS.CallTimers(FALSE);
_progress := 321;
END_IF;

//Check if program already set
// Screwing running: checking if the program is already set.
IF _progress = 321 THEN
IF _RequiredScrewingProgram = Inputs.ScrewingProgram THEN
ScrewingProgram := _RequiredScrewingProgram;
Expand All @@ -846,8 +844,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 322;
END_IF;
END_IF;

//Set program
// Screwing running: waiting for the program number is mirrored back.
IF _progress = 322 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#522, eAxoMessageCategory#Warning);
Expand All @@ -862,9 +859,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 323;
END_IF;
END_IF;


// wait for screwdriver ready
// Screwing running: waiting for 'InCycle' flag to be reseted.
IF _progress = 323 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#523, eAxoMessageCategory#Warning);
Expand All @@ -876,8 +871,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 324;
END_IF;
END_IF;

// wait for screwdriver ready
// Screwing running: waiting for the device to be Ready.
IF _progress = 324 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#524, eAxoMessageCategory#Warning);
Expand All @@ -889,8 +883,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 325;
END_IF;
END_IF;

// start screwing cycle
// Screwing running: waiting for the screwing cycle is started.
IF _progress = 325 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#525, eAxoMessageCategory#Warning);
Expand All @@ -905,8 +898,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 326;
END_IF;
END_IF;

// wait for screwing cycle end
// Screwing running: waiting for the screwing cycle is finished.
IF _progress = 326 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#526, eAxoMessageCategory#Warning);
Expand All @@ -918,9 +910,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 327;
END_IF;
END_IF;


// wait for screwing cycle end
// Screwing running: waiting for the overall screwing results are ready.
IF _progress = 327 THEN
IF _infoTimer.output THEN
TaskMessenger.Activate( UINT#527, eAxoMessageCategory#Warning);
Expand All @@ -941,8 +931,7 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_progress := 328;
END_IF;
END_IF;

// finished
// Screwing finished.
IF _progress = 328 THEN
_progress := 0;
StartScrewingTask.DoneWhen(TRUE);
Expand Down Expand Up @@ -996,7 +985,6 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
Status.Error.Id := UINT#1232;
RETURN;
END_IF;

END_METHOD

///<summary>
Expand All @@ -1019,7 +1007,6 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
SetScrewingProgram := SetScrewingProgramTask.Invoke(THIS);
END_METHOD


///<summary>
/// This method starts the screwing process
///<summary>
Expand All @@ -1046,7 +1033,6 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening

METHOD PROTECTED OVERRIDE ManualControl
_RequiredScrewingProgram := RequiredScrewingProgram;

END_METHOD

METHOD PRIVATE CallTimers
Expand All @@ -1057,8 +1043,6 @@ NAMESPACE AXOpen.Components.Desoutter.Tightening
_infoTimer.OnDelay(THIS, signal AND Config.InfoTime > LT#0S ,Config.InfoTime);
_errorTimer.OnDelay(THIS, signal AND Config.ErrorTime > LT#0S , Config.ErrorTime);
END_METHOD


END_CLASS
END_NAMESPACE

Expand Down
55 changes: 15 additions & 40 deletions ...desoutter.tightening/src/AXOpen.Components.Desoutter.Tightening/AxoCVIC_II/AxoCVICC_II.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,54 +337,29 @@ public string ActionDescription
actionDescriptionDict.Add(50, "Restore has been executed.");

actionDescriptionDict.Add(100, "Reset started.");
actionDescriptionDict.Add(300, "Reset running.");
actionDescriptionDict.Add(301, "Reset running.");
actionDescriptionDict.Add(302, "Reset running.");
actionDescriptionDict.Add(303, "Reset running.");
actionDescriptionDict.Add(304, "Reset running.");
actionDescriptionDict.Add(305, "Reset running.");
actionDescriptionDict.Add(306, "Reset running.");
actionDescriptionDict.Add(307, "Reset running.");
actionDescriptionDict.Add(308, "Reset running.");
actionDescriptionDict.Add(309, "Reset running.");
actionDescriptionDict.Add(300, "Reset running: waiting for 'Failed' flag to be reseted.");
actionDescriptionDict.Add(301, "Reset running: waiting for 'InCycle' flag to be reseted.");
actionDescriptionDict.Add(302, "Reset running: waiting for the device to be Ready.");
actionDescriptionDict.Add(303, "Reset finished.");
actionDescriptionDict.Add(101, "Reset finished succesfully.");
actionDescriptionDict.Add(102, "Reset restored.");

actionDescriptionDict.Add(110, "Set screwing program started.");
actionDescriptionDict.Add(310, "Set screwing program running.");
actionDescriptionDict.Add(311, "Set screwing program running.");
actionDescriptionDict.Add(312, "Set screwing program running.");
actionDescriptionDict.Add(313, "Set screwing program running.");
actionDescriptionDict.Add(314, "Set screwing program running.");
actionDescriptionDict.Add(315, "Set screwing program running.");
actionDescriptionDict.Add(316, "Set screwing program running.");
actionDescriptionDict.Add(317, "Set screwing program running.");
actionDescriptionDict.Add(318, "Set screwing program running.");
actionDescriptionDict.Add(319, "Set screwing program running.");
actionDescriptionDict.Add(310, "Set screwing program running: waiting for the program number is mirrored back.");
actionDescriptionDict.Add(311, "Set screwing program finished. ");
actionDescriptionDict.Add(111, "Set screwing program finished succesfully.");
actionDescriptionDict.Add(112, "Set screwing program restored.");

actionDescriptionDict.Add(120, "Screwing started.");
actionDescriptionDict.Add(320, "Screwing running.");
actionDescriptionDict.Add(321, "Screwing running.");
actionDescriptionDict.Add(322, "Screwing running.");
actionDescriptionDict.Add(323, "Screwing running.");
actionDescriptionDict.Add(324, "Screwing running.");
actionDescriptionDict.Add(325, "Screwing running.");
actionDescriptionDict.Add(326, "Screwing running.");
actionDescriptionDict.Add(327, "Screwing running.");
actionDescriptionDict.Add(328, "Screwing running.");
actionDescriptionDict.Add(329, "Screwing running.");
actionDescriptionDict.Add(330, "Screwing running.");
actionDescriptionDict.Add(331, "Screwing running.");
actionDescriptionDict.Add(332, "Screwing running.");
actionDescriptionDict.Add(333, "Screwing running.");
actionDescriptionDict.Add(334, "Screwing running.");
actionDescriptionDict.Add(335, "Screwing running.");
actionDescriptionDict.Add(336, "Screwing running.");
actionDescriptionDict.Add(337, "Screwing running.");
actionDescriptionDict.Add(338, "Screwing running.");
actionDescriptionDict.Add(339, "Screwing running.");
actionDescriptionDict.Add(320, "Screwing running: reseting the previous results.");
actionDescriptionDict.Add(321, "Screwing running: checking if the program is already set.");
actionDescriptionDict.Add(322, "Screwing running: waiting for the program number is mirrored back.");
actionDescriptionDict.Add(323, "Screwing running: waiting for 'InCycle' flag to be reseted.");
actionDescriptionDict.Add(324, "Screwing running: waiting for the device to be Ready.");
actionDescriptionDict.Add(325, "Screwing running: waiting for the screwing cycle is started.");
actionDescriptionDict.Add(326, "Screwing running: waiting for the screwing cycle is finished.");
actionDescriptionDict.Add(327, "Screwing running: waiting for the overall screwing results are ready.");
actionDescriptionDict.Add(328, "Screwing finished.");
actionDescriptionDict.Add(121, "Screwing finished succesfully.");
actionDescriptionDict.Add(122, "Screwing restored.");

Expand Down
Loading
Loading