Add support for enforcing https, update JVM version to 17 #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version number to indicate breaking change. Fix
giarc3
approved these changes
Nov 14, 2025
src/main/java/com/ironcorelabs/tenantsecurity/kms/v1/TenantSecurityClient.java
Outdated
Show resolved
Hide resolved
Member
Author
|
The examples are broken because they're pointing to the version I'm about to publish. I'm gonna publish and then re-run the builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change and moves to a
Builderstyle for building the TenantSecurityClient. Instead of doingnew TenantSecurityClient(...)now we donew TenantSecurityClient.Builder(...).build(). This allows us to get rid of the overloads and make the api more clear.There is a new flag for
allowInsecureHttpwhich defaults to false. If you want the old behavior back (hopefully only for testing envs) then you can callallowInsecureHttp(true)on the builder.This also changes the version of the JVM we build for from 11 to 17.
This also fixes #16